-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix incorrect usage of add_handled_dependencies
#10270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
force-pushed
the
handle-multidir-dep-updates-correctly
branch
from
July 22, 2024 19:44
5d9d9c1
to
34fdbe1
Compare
jakecoffman
changed the title
handle multi-dir updates existing PRs correctly
refactor DependencySnapshot to fix a bug with add_handled_directories
Jul 22, 2024
jakecoffman
changed the title
refactor DependencySnapshot to fix a bug with add_handled_directories
refactor DependencySnapshot to fix a bug with Jul 22, 2024
add_handled_dependencies
jakecoffman
changed the title
refactor DependencySnapshot to fix a bug with
fix incorrect usage of Jul 23, 2024
add_handled_dependencies
add_handled_dependencies
Nishnha
reviewed
Jul 23, 2024
abdulapopoola
approved these changes
Jul 23, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Finally got to the root cause of the issue I've been hunting, previous PRs for additional context:
The issue was caused by DependencySnapshot's methods needing
current_directory
being set beforehand, but several places we were callingadd_handled_dependencies
it wasn't set yet.To fix that, I made a helper
mark_group_handled
which is appropriate to call in those places. It's also a good place to start usingdirectory
in the existing group PR data, but I'll save that for another PR.This has also fixed a bad test
vu-group-multidir-semver.txt
had an incorrect second assertion. There are 4 dependencies across 2 directories, with a major and minor group all 4 should be updated in 2 PRs. This is fixed!Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
I will manually test against our repo that was getting individual PRs when it should not have.
Checklist